Github hook is hyperactive
Before v3 of the API and the removal of API v1, we were using a self-hosted github hook that used Pivotal's v1 API. After the release, we migrated to Pivotal's built-in github hook in the v3 API. However, my team had to disable it because it is not working very well for our workflow.
The first issue is likely a bug. Any commit being recorded moves the story to a Started state, even if the story was in a state other than not started. So a developer who marks a story finished right before pushing code is surprised to find his story moved back to started. The hook we used before did not alter the story state unless it was specifically instructed in the commit message.
Secondly, our team manages several remote git branches at any one time and we often merge between them to keep the branches up to date with the master branch. Each time we push a merge to a remote branch, all stories with commits that were merged are getting the comment recorded again. This fills up a story's comments section and results in a flood of emails to people subscribed to a story. The hook we used before was configured to only make comments for commits in the master branch. That's not ideal, but much better than all the duplicates. I'd like to see Pivotal's hook either do that or do some form of de-duping to only record comments the first time a commit is seen by the hook.
The first issue is likely a bug. Any commit being recorded moves the story to a Started state, even if the story was in a state other than not started. So a developer who marks a story finished right before pushing code is surprised to find his story moved back to started. The hook we used before did not alter the story state unless it was specifically instructed in the commit message.
Secondly, our team manages several remote git branches at any one time and we often merge between them to keep the branches up to date with the master branch. Each time we push a merge to a remote branch, all stories with commits that were merged are getting the comment recorded again. This fills up a story's comments section and results in a flood of emails to people subscribed to a story. The hook we used before was configured to only make comments for commits in the master branch. That's not ideal, but much better than all the duplicates. I'd like to see Pivotal's hook either do that or do some form of de-duping to only record comments the first time a commit is seen by the hook.
2
people have this problem
I have this problem, too!
Tell me when someone solves it.
The more people who report this problem, the more it gets noticed.
The more people who report this problem, the more it gets noticed.
The company marked this problem solved.
-
Inappropriate?Hi Chris, thanks for the info. The first is definitely a bug, we'll get that fixed. For the second issue, I'm not sure we can distinguish normal commits from merges, but we'll at least try and avoid adding comments for the same commit multiple times.
-
Inappropriate?We haven't see the first problem, but I've noticed that when a store is marked as, say delivered, and it gets merged to/from a branch it reverts to finished. Perhaps if the story is already finished the post-commit hook shouldn't modify it (or comment).
-
Inappropriate?I just tried the hook again after letting a month's worth of bug fixes go in. Looks like the story state change issue is fixed but we're still getting a new comment on the story each time a commit is merged between remote branches. Since most of our changes happen on topic branches and are then merged to master, this means at least two comments per commit and a flood of emails if many commits are merged at once.
Please let me know if there's any update on this issue.
I’m frustrated
Loading Profile...



EMPLOYEE
